netdev - Re: [PATCH] mm: Replace all open encodings for NUMA_NO

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20181124140554.GG3175@vkoul-mobl.Dlink>
Date:   Sat, 24 Nov 2018 19:35:54 +0530
From:   Vinod Koul <vkoul@...nel.org>
To:     Anshuman Khandual <anshuman.khandual@....com>
Cc:     linux-mm@...ck.org, linux-kernel@...r.kernel.org,
        ocfs2-devel@....oracle.com, linux-fbdev@...r.kernel.org,
        dri-devel@...ts.freedesktop.org, netdev@...r.kernel.org,
        intel-wired-lan@...ts.osuosl.org, linux-media@...r.kernel.org,
        iommu@...ts.linux-foundation.org, linux-rdma@...r.kernel.org,
        dmaengine@...r.kernel.org, linux-block@...r.kernel.org,
        sparclinux@...r.kernel.org, linuxppc-dev@...ts.ozlabs.org,
        linux-ia64@...r.kernel.org, linux-alpha@...r.kernel.org,
        akpm@...ux-foundation.org, jiangqi903@...il.com, hverkuil@...all.nl
Subject: Re: [PATCH] mm: Replace all open encodings for NUMA_NO_NODE

On 23-11-18, 15:24, Anshuman Khandual wrote:

> --- a/drivers/dma/dmaengine.c
> +++ b/drivers/dma/dmaengine.c
> @@ -386,7 +386,8 @@ EXPORT_SYMBOL(dma_issue_pending_all);
>  static bool dma_chan_is_local(struct dma_chan *chan, int cpu)
>  {
>  	int node = dev_to_node(chan->device->dev);
> -	return node == -1 || cpumask_test_cpu(cpu, cpumask_of_node(node));
> +	return node == NUMA_NO_NODE ||
> +		cpumask_test_cpu(cpu, cpumask_of_node(node));
>  }

I do not see dev_to_node being updated first, that returns -1 so I would
prefer to check for -1 unless it return NUMA_NO_NODE

-- 
~Vinod