netdev - Re: [PATCH iproute2-next] tc: fq: support ce

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <d74e16dd-1c40-dd6d-4e47-69ae45cc32b9@gmail.com>
Date:   Sat, 24 Nov 2018 08:38:50 -0700
From:   David Ahern <dsahern@...il.com>
To:     Eric Dumazet <edumazet@...gle.com>
Cc:     netdev <netdev@...r.kernel.org>,
        Eric Dumazet <eric.dumazet@...il.com>
Subject: Re: [PATCH iproute2-next] tc: fq: support ce_threshold attribute

On 11/23/18 11:37 PM, Eric Dumazet wrote:
> Kernel commit 48872c11b772 ("net_sched: sch_fq: add dctcp-like marking")
> added support for TCA_FQ_CE_THRESHOLD attribute.
> 
> This patch adds iproute2 support for it.
> 
> It also makes sure fq_print_xstats() can deal with smaller tc_fq_qd_stats
> structures given by older kernels.
> 
> Usage :
> 
> FQATTRS="ce_threshold 4ms"
> TXQS=8
> 
> for ETH in eth0
> do
>  tc qd del dev $ETH root 2>/dev/null
>  tc qd add dev $ETH root handle 1: mq
>  for i in `seq 1 $TXQS`
>  do
>   tc qd add dev $ETH parent 1:$i fq $FQATTRS
>  done
> done
> 
> Signed-off-by: Eric Dumazet <edumazet@...gle.com>
> ---
>  tc/q_fq.c | 32 ++++++++++++++++++++++++++++----
>  1 file changed, 28 insertions(+), 4 deletions(-)
> 


applied to iproute2-next. Thanks

Eric: the fq man page is out of date. Can you update it as well - not
just this argument but other missing ones? Thanks