netdev - Re: [PATCH net] team: no need to do team_notify_peers or team_mcast

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20181123.171838.392643964813498639.davem@davemloft.net>
Date:   Fri, 23 Nov 2018 17:18:38 -0800 (PST)
From:   David Miller <davem@...emloft.net>
To:     liuhangbin@...il.com
Cc:     netdev@...r.kernel.org, jiri@...nulli.us, lucien.xin@...il.com
Subject: Re: [PATCH net] team: no need to do team_notify_peers or
 team_mcast_rejoin when disabling port

From: Hangbin Liu <liuhangbin@...il.com>
Date: Thu, 22 Nov 2018 16:15:28 +0800

> team_notify_peers() will send ARP and NA to notify peers. team_mcast_rejoin()
> will send multicast join group message to notify peers. We should do this when
> enabling/changed to a new port. But it doesn't make sense to do it when a port
> is disabled.
> 
> On the other hand, when we set mcast_rejoin_count to 2, and do a failover,
> team_port_disable() will increase mcast_rejoin.count_pending to 2 and then
> team_port_enable() will increase mcast_rejoin.count_pending to 4. We will send
> 4 mcast rejoin messages at latest, which will make user confused. The same
> with notify_peers.count.
> 
> Fix it by deleting team_notify_peers() and team_mcast_rejoin() in
> team_port_disable().
> 
> Reported-by: Liang Li <liali@...hat.com>
> Fixes: fc423ff00df3a ("team: add peer notification")
> Fixes: 492b200efdd20 ("team: add support for sending multicast rejoins")
> Signed-off-by: Hangbin Liu <liuhangbin@...il.com>

Applied.