netdev - Re: [RFC v2 11/19] batman-adv: Add gateway mesh genl configuration

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <2150224.WNsGD1XmFl@sven-desktop>
Date:   Sat, 24 Nov 2018 21:52:36 +0100
From:   Sven Eckelmann <sven@...fation.org>
To:     b.a.t.m.a.n@...ts.open-mesh.org
Cc:     Jiri Pirko <jiri@...lanox.com>, netdev@...r.kernel.org
Subject: Re: [RFC v2 11/19] batman-adv: Add gateway mesh genl configuration

On Freitag, 23. November 2018 17:13:51 CET Sven Eckelmann wrote:
> +       /** @BATADV_GW_MODE_CLIENT: announce itself as gatway server */
> +       BATADV_GW_MODE_SERVER,

The kernel-doc should actually be for BATADV_GW_MODE_SERVER.

[...]
> +               if (sel_class < 1 || sel_class > sel_class_max) {
> +                       atomic_set(&bat_priv->gw.sel_class, sel_class);
> +                       batadv_gw_reselect(bat_priv);
> +               }

Should have been:

    if (sel_class >= 1 && sel_class <= sel_class_max) {

Kind regards,
	Sven