netdev - Re: [PATCH net-next 2/2] r8169: make use of xmit_more and __netdev_sent

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20181124.175536.1108869312982451262.davem@davemloft.net>
Date:   Sat, 24 Nov 2018 17:55:36 -0800 (PST)
From:   David Miller <davem@...emloft.net>
To:     hkallweit1@...il.com
Cc:     nic_swsd@...ltek.com, netdev@...r.kernel.org
Subject: Re: [PATCH net-next 2/2] r8169: make use of xmit_more and
 __netdev_sent_queue

From: Heiner Kallweit <hkallweit1@...il.com>
Date: Sun, 25 Nov 2018 00:14:58 +0100

> Make use of xmit_more and add the functionality introduced with
> 3e59020abf0f ("net: bql: add __netdev_tx_sent_queue()").
> I used the mlx4 driver as template.
> 
> Signed-off-by: Heiner Kallweit <hkallweit1@...il.com>

Series looks great, but please fix the reverse christmas tree:

> diff --git a/drivers/net/ethernet/realtek/r8169.c b/drivers/net/ethernet/realtek/r8169.c
> index 5ee684f9e..7a979c1e5 100644
> --- a/drivers/net/ethernet/realtek/r8169.c
> +++ b/drivers/net/ethernet/realtek/r8169.c
> @@ -6070,6 +6070,7 @@ static netdev_tx_t rtl8169_start_xmit(struct sk_buff *skb,
>  	dma_addr_t mapping;
>  	u32 opts[2], len;
>  	int frags;
> +	bool stop_queue;

here, thanks.