netdev - Re: [PATCH 6/8] socket: Add struct sock

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20181124.180903.1457197646957052282.davem@davemloft.net>
Date:   Sat, 24 Nov 2018 18:09:03 -0800 (PST)
From:   David Miller <davem@...emloft.net>
To:     willemdebruijn.kernel@...il.com
Cc:     deepa.kernel@...il.com, linux-kernel@...r.kernel.org,
        netdev@...r.kernel.org, viro@...iv.linux.org.uk, arnd@...db.de,
        y2038@...ts.linaro.org
Subject: Re: [PATCH 6/8] socket: Add struct sock_timeval

From: Willem de Bruijn <willemdebruijn.kernel@...il.com>
Date: Sat, 24 Nov 2018 14:37:42 -0500

> On Sat, Nov 24, 2018 at 4:00 AM Deepa Dinamani <deepa.kernel@...il.com> wrote:
>> diff --git a/include/uapi/linux/time.h b/include/uapi/linux/time.h
>> index 04d5587f30d3..106f9398c285 100644
>> --- a/include/uapi/linux/time.h
>> +++ b/include/uapi/linux/time.h
>> @@ -70,6 +70,11 @@ struct __kernel_old_timeval {
>>  };
>>  #endif
>>
>> +struct sock_timeval {
>> +       long long tv_sec;
>> +       long long tv_usec;
> 
> should these use fixed-width type __u64?
> 
> even if all data models define long long as 64-bit, that might be more
> descriptive.

Agreed.