netdev - Re: [PATCH net-next 1/2] udp: msg

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CAF=yD-+_pHR6S+JYxnJmRBgEWo3i1Pv-=Ku_Ni4ofShupMS6gA@mail.gmail.com>
Date:   Sat, 24 Nov 2018 21:13:08 -0500
From:   Willem de Bruijn <willemdebruijn.kernel@...il.com>
To:     David Miller <davem@...emloft.net>
Cc:     Network Development <netdev@...r.kernel.org>,
        Willem de Bruijn <willemb@...gle.com>
Subject: Re: [PATCH net-next 1/2] udp: msg_zerocopy

On Sat, Nov 24, 2018 at 8:58 PM David Miller <davem@...emloft.net> wrote:
>
> From: Willem de Bruijn <willemdebruijn.kernel@...il.com>
> Date: Sat, 24 Nov 2018 14:24:30 -0500
>
> > diff --git a/net/ipv4/ip_output.c b/net/ipv4/ip_output.c
> > index c09219e7f230..2d1e4b67a1e8 100644
> > --- a/net/ipv4/ip_output.c
> > +++ b/net/ipv4/ip_output.c
> > @@ -868,6 +868,7 @@ static int __ip_append_data(struct sock *sk,
> >  {
> >       struct inet_sock *inet = inet_sk(sk);
> >       struct sk_buff *skb;
> > +     struct ubuf_info *uarg = NULL;
>
> Reverse christmas tree, please.

Oh right, sorry.

Will wait with v2 for a day or two, in case anyone else has comments.
Thanks for the quick review!