netdev - Re: [PATCH net] net: phy: add workaround for issue where PHY driver doesn't bind to the device

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20181126132415.GB13184@lunn.ch>
Date:   Mon, 26 Nov 2018 14:24:15 +0100
From:   Andrew Lunn <andrew@...n.ch>
To:     Heiner Kallweit <hkallweit1@...il.com>
Cc:     Florian Fainelli <f.fainelli@...il.com>,
        David Miller <davem@...emloft.net>,
        "netdev@...r.kernel.org" <netdev@...r.kernel.org>
Subject: Re: [PATCH net] net: phy: add workaround for issue where PHY driver
 doesn't bind to the device

On Fri, Nov 23, 2018 at 07:41:29PM +0100, Heiner Kallweit wrote:
> After switching the r8169 driver to use phylib some user reported that
> their network is broken. This was caused by the genphy PHY driver being
> used instead of the dedicated PHY driver for the RTL8211B. Users
> reported that loading the Realtek PHY driver module upfront fixes the
> issue. See also this mail thread:
> https://marc.info/?t=154279781800003&r=1&w=2
> The issue is quite weird and the root cause seems to be somewhere in
> the base driver core. The patch works around the issue and may be
> removed once the actual issue is fixed.
> 
> The Fixes tag refers to the first reported occurrence of the issue.
> The issue itself may have been existing much longer and it may affect
> users of other network chips as well. Users typically will recognize
> this issue only if their PHY stops working when being used with the
> genphy driver.
> 
> Fixes: f1e911d5d0df ("r8169: add basic phylib support")
> Signed-off-by: Heiner Kallweit <hkallweit1@...il.com>
> ---
> I'm not sure how long it will take to find and fix the root cause of
> the issue. With this workaround affected users have a working network
> again from 4.19.5 at least.

Hi Heiner

Lets go with this for the moment. That gives us time to try to figure
out what is going on to cause the wrong driver to be used for the
r8169.

Reviewed-by: Andrew Lunn <andrew@...n.ch>

    Andrew