netdev - RE: [PATCH net-next 1/8] dpaa2-eth: Add basic XDP support

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <AM6PR04MB500090326067E759B95C5E4894D70@AM6PR04MB5000.eurprd04.prod.outlook.com>
Date:   Mon, 26 Nov 2018 07:32:18 +0000
From:   Ioana Ciocoi Radulescu <ruxandra.radulescu@....com>
To:     David Ahern <dsahern@...il.com>,
        "netdev@...r.kernel.org" <netdev@...r.kernel.org>,
        "davem@...emloft.net" <davem@...emloft.net>
CC:     Ioana Ciornei <ioana.ciornei@....com>
Subject: RE: [PATCH net-next 1/8] dpaa2-eth: Add basic XDP support

> -----Original Message-----
> From: David Ahern <dsahern@...il.com>
> Sent: Saturday, November 24, 2018 11:49 PM
> To: Ioana Ciocoi Radulescu <ruxandra.radulescu@....com>;
> netdev@...r.kernel.org; davem@...emloft.net
> Cc: Ioana Ciornei <ioana.ciornei@....com>
> Subject: Re: [PATCH net-next 1/8] dpaa2-eth: Add basic XDP support
> 
> On 11/23/18 9:56 AM, Ioana Ciocoi Radulescu wrote:
> > @@ -215,6 +255,7 @@ static void dpaa2_eth_rx(struct dpaa2_eth_priv
> *priv,
> >  	struct dpaa2_fas *fas;
> >  	void *buf_data;
> >  	u32 status = 0;
> > +	u32 xdp_act;
> >
> >  	/* Tracing point */
> >  	trace_dpaa2_rx_fd(priv->net_dev, fd);
> > @@ -231,8 +272,14 @@ static void dpaa2_eth_rx(struct dpaa2_eth_priv
> *priv,
> >  	percpu_extras = this_cpu_ptr(priv->percpu_extras);
> >
> >  	if (fd_format == dpaa2_fd_single) {
> > +		xdp_act = run_xdp(priv, ch, (struct dpaa2_fd *)fd, vaddr);
> > +		if (xdp_act != XDP_PASS)
> > +			return;
> 
> please bump the rx counters (packets and bytes) regardless of what XDP
> outcome is.
> 
> Same for Tx; packets and bytes counter should be bumped for packets
> redirected by XDP.

Thanks for the feedback, I wasn't sure whether I should count them
as regular packets or not. I'll make the change in v2.

Ioana