netdev - RE: [PATCH net-next 1/8] dpaa2-eth: Add basic XDP support

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [day] [month] [year] [list]

Message-ID: <VI1PR04MB47992C40489ADAAFB0E9C47EF2D70@VI1PR04MB4799.eurprd04.prod.outlook.com>
Date:   Mon, 26 Nov 2018 11:36:39 +0000
From:   Camelia Alexandra Groza <camelia.groza@....com>
To:     Ioana Ciocoi Radulescu <ruxandra.radulescu@....com>
CC:     "netdev@...r.kernel.org" <netdev@...r.kernel.org>,
        "davem@...emloft.net" <davem@...emloft.net>
Subject: RE: [PATCH net-next 1/8] dpaa2-eth: Add basic XDP support

> -----Original Message-----
> From: netdev-owner@...r.kernel.org <netdev-owner@...r.kernel.org>
> On Behalf Of Ioana Ciocoi Radulescu
> Sent: Friday, November 23, 2018 18:57
> To: netdev@...r.kernel.org; davem@...emloft.net
> Subject: [PATCH net-next 1/8] dpaa2-eth: Add basic XDP support
> 
> +static int dpaa2_eth_change_mtu(struct net_device *dev, int new_mtu)
> +{
> +	struct dpaa2_eth_priv *priv = netdev_priv(dev);
> +	int err;
> +
> +	if (!priv->xdp_prog)
> +		goto out;
> +
> +	if (!xdp_mtu_valid(priv, new_mtu))
> +		return -EINVAL;

An error message would be helpful to let the user know which MTU values are acceptable in XDP context.