netdev - Re: [PATCH net] be2net: Fix NULL pointer dereference in be_tx

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20181127.145108.1921689913131989867.davem@davemloft.net>
Date:   Tue, 27 Nov 2018 14:51:08 -0800 (PST)
From:   David Miller <davem@...emloft.net>
To:     poros@...hat.com
Cc:     netdev@...r.kernel.org, ivecera@...hat.com
Subject: Re: [PATCH net] be2net: Fix NULL pointer dereference in
 be_tx_timeout()

From: Petr Oros <poros@...hat.com>
Date: Thu, 22 Nov 2018 15:24:07 +0100

> @@ -4700,8 +4700,11 @@ int be_update_queues(struct be_adapter *adapter)
>  	struct net_device *netdev = adapter->netdev;
>  	int status;
>  
> -	if (netif_running(netdev))
> +	if (netif_running(netdev)) {
> +		/* prevent netdev watchdog during tx queue destroy */
> +		netif_carrier_off(netdev);
>  		be_close(netdev);
> +	}

This will make userspace networking daemons will think that the link
went down.

This absolutely should not be a side effect of making a simple
TX queue configuration change via ethtool.