netdev - Re: [PATCH net-next v2 0/3] net: bridge: add an option to disabe linklocal learning

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20181127.150433.1840968917758138562.davem@davemloft.net>
Date:   Tue, 27 Nov 2018 15:04:33 -0800 (PST)
From:   David Miller <davem@...emloft.net>
To:     nikolay@...ulusnetworks.com
Cc:     netdev@...r.kernel.org, roopa@...ulusnetworks.com, andrew@...n.ch,
        bridge@...ts.linux-foundation.org
Subject: Re: [PATCH net-next v2 0/3] net: bridge: add an option to disabe
 linklocal learning

From: Nikolay Aleksandrov <nikolay@...ulusnetworks.com>
Date: Sat, 24 Nov 2018 04:34:19 +0200

> This set adds a new bridge option which can control learning from
> link-local packets, by default learning is on to be consistent and avoid
> breaking users expectations. If the new no_linklocal_learn option is
> enabled then the bridge will stop learning from link-local packets.
> 
> In order to save space for future boolean options, patch 01 adds a new
> bool option API that uses a bitmask to control boolean options. The
> bridge is by far the largest netlink attr user and we keep adding simple
> boolean options which waste nl attr ids and space. We're not directly
> mapping these to the in-kernel bridge flags because some might require
> more complex configuration changes (e.g. if we were to add the per port
> vlan stats now, it'd require multiple checks before changing value).
> Any new bool option needs to be handled by both br_boolopt_toggle and get
> in order to be able to retrieve its state later. All such options are
> automatically exported via netlink. The behaviour of setting such
> options is consistent with netlink option handling when a missing
> option is being set (silently ignored), e.g. when a newer iproute2 is used
> on older kernel. All supported options are exported via bm's optmask
> when dumping the new attribute.
> 
> v2: address Andrew Lunn's comments, squash a minor change into patch 01,
>     export all supported options via optmask when dumping, add patch 03,
>     pass down extack so options can return meaningful errors, add
>     WARN_ON on unsupported options (should not happen)

Series applied, thanks Nikolay.