netdev - Re: [PATCH v3 net] lan743x: fix return value for lan743x_tx_napi

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Tue, 27 Nov 2018 16:30:12 -0800 (PST)
From:   David Miller <davem@...emloft.net>
To:     Bryan.Whitehead@...rochip.com
Cc:     netdev@...r.kernel.org, UNGLinuxDriver@...rochip.com
Subject: Re: [PATCH v3 net] lan743x: fix return value for
 lan743x_tx_napi_poll

From: Bryan Whitehead <Bryan.Whitehead@...rochip.com>
Date: Mon, 26 Nov 2018 12:04:57 -0500

> The lan743x driver, when under heavy traffic load, has been noticed
> to sometimes hang, or cause a kernel panic.
> 
> Debugging reveals that the TX napi poll routine was returning
> the wrong value, 'weight'. Most other drivers return 0.
> And call napi_complete, instead of napi_complete_done.
> 
> Additionally when creating the tx napi poll routine.
> Changed netif_napi_add, to netif_tx_napi_add.
> 
> Updates for v3:
>     changed 'fixes' tag to match defined format
> 
> Updates for v2:
> use napi_complete, instead of napi_complete_done in
>     lan743x_tx_napi_poll
> use netif_tx_napi_add, instead of netif_napi_add for
>     registration of tx napi poll routine
> 
> fixes: 23f0703c125b ("lan743x: Add main source files for new lan743x driver")
> Signed-off-by: Bryan Whitehead <Bryan.Whitehead@...rochip.com>

Applied and queued up for -stable.