netdev - Re: [PATCH net] be2net: Fix NULL pointer dereference in be_tx

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20181128.113202.2188317411211917251.davem@davemloft.net>
Date:   Wed, 28 Nov 2018 11:32:02 -0800 (PST)
From:   David Miller <davem@...emloft.net>
To:     ivecera@...hat.com
Cc:     poros@...hat.com, netdev@...r.kernel.org
Subject: Re: [PATCH net] be2net: Fix NULL pointer dereference in
 be_tx_timeout()

From: Ivan Vecera <ivecera@...hat.com>
Date: Wed, 28 Nov 2018 20:29:44 +0100

> And the right way? netif_device_detach() that does not fire
> linkwatch events?

Allocate all the TX queue resources first.

Do not modify the TX queue configuration in any way whatsoever
meanwhile.

Only after successfully allocating the resources, should you
commit them to the hardware configuration.

That way there is no problem and you don't have to worry about
the OOPS in question.