netdev - Re: [PATCH] selinux: add support for RTM_NEWCHAIN, RTM_DELCHAIN, and RTM

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Wed, 28 Nov 2018 11:34:59 -0800 (PST)
From:   David Miller <davem@...emloft.net>
To:     paul@...l-moore.com
Cc:     selinux@...r.kernel.org, netdev@...r.kernel.org, jiri@...lanox.com
Subject: Re: [PATCH] selinux: add support for RTM_NEWCHAIN, RTM_DELCHAIN,
 and RTM_GETCHAIN

From: Paul Moore <paul@...l-moore.com>
Date: Wed, 28 Nov 2018 13:47:25 -0500

> On Wed, Nov 28, 2018 at 1:44 PM Paul Moore <paul@...l-moore.com> wrote:
>> Commit 32a4f5ecd738 ("net: sched: introduce chain object to uapi")
>> added new RTM_* definitions without properly updating SELinux, this
>> patch adds the necessary SELinux support.
>>
>> While there was a BUILD_BUG_ON() in the SELinux code to protect from
>> exactly this case, it was bypassed in the broken commit.  In order to
>> hopefully prevent this from happening in the future, add additional
>> comments which provide some instructions on how to resolve the
>> BUILD_BUG_ON() failures.
>>
>> Fixes: 32a4f5ecd738 ("net: sched: introduce chain object to uapi")
>> Cc: <stable@...r.kernel.org> # 4.19
>> Signed-off-by: Paul Moore <paul@...l-moore.com>
>> ---
>>  security/selinux/nlmsgtab.c |   13 ++++++++++++-
>>  1 file changed, 12 insertions(+), 1 deletion(-)
> 
> I'm building a test kernel right now, assuming all goes well I'm going
> to send this up to Linus for v4.20.

Acked-by: David S. Miller <davem@...emloft.net>