netdev - Re: [PATCH bpf-next v2 0/3] bpf: add sk_msg helper sk_msg_pop

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <ae4ce061-6cbf-9f17-3aad-5e760edbe9dd@iogearbox.net>
Date:   Wed, 28 Nov 2018 22:12:03 +0100
From:   Daniel Borkmann <daniel@...earbox.net>
To:     John Fastabend <john.fastabend@...il.com>, ast@...nel.org
Cc:     netdev@...r.kernel.org
Subject: Re: [PATCH bpf-next v2 0/3] bpf: add sk_msg helper sk_msg_pop_data

On 11/26/2018 11:16 PM, John Fastabend wrote:
> After being able to add metadata to messages with sk_msg_push_data we
> have also found it useful to be able to "pop" this metadata off before
> sending it to applications in some cases. This series adds a new helper
> sk_msg_pop_data() and the associated patches to add tests and tools/lib
> support.
> 
> Thanks!
> 
> v2: Daniel caught that we missed adding sk_msg_pop_data to the changes
>     data helper so that the verifier ensures BPF programs revalidate
>     data after using this helper. Also improve documentation adding a
>     return description and using RST syntax per Quentin's comment. And
>     delta calculations for DROP with pop'd data (albeit a strange set
>     of operations for a program to be doing) had potential to be
>     incorrect possibly confusing user space applications, so fix it.
> 
> John Fastabend (3):
>   bpf: helper to pop data from messages
>   bpf: add msg_pop_data helper to tools
>   bpf: test_sockmap, add options for msg_pop_data() helper usage
> 
>  include/uapi/linux/bpf.h                        |  13 +-
>  net/core/filter.c                               | 169 ++++++++++++++++++++++++
>  net/ipv4/tcp_bpf.c                              |  14 +-
>  tools/include/uapi/linux/bpf.h                  |  13 +-
>  tools/testing/selftests/bpf/bpf_helpers.h       |   2 +
>  tools/testing/selftests/bpf/test_sockmap.c      | 127 +++++++++++++++++-
>  tools/testing/selftests/bpf/test_sockmap_kern.h |  70 ++++++++--
>  7 files changed, 386 insertions(+), 22 deletions(-)
> 

Applied to bpf-next, thanks!