netdev - Re: [PATCH iproute2] ss: add support for delivered and delivered

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <2a7b9fa6-b072-c45b-6e0e-8389eddc4576@gmail.com>
Date:   Wed, 28 Nov 2018 22:16:19 -0700
From:   David Ahern <dsahern@...il.com>
To:     Eric Dumazet <eric.dumazet@...il.com>,
        Stephen Hemminger <stephen@...workplumber.org>,
        Eric Dumazet <edumazet@...gle.com>
Cc:     netdev <netdev@...r.kernel.org>, Phil Sutter <phil@....cc>
Subject: Re: [PATCH iproute2] ss: add support for delivered and delivered_ce
 fields

On 11/28/18 10:10 PM, Eric Dumazet wrote:
> 
> 
> On 11/28/2018 04:01 PM, Stephen Hemminger wrote:
>> On Mon, 26 Nov 2018 14:29:53 -0800
>> Eric Dumazet <edumazet@...gle.com> wrote:
>>
>>> Kernel support was added in linux-4.18 in commit feb5f2ec6464
>>> ("tcp: export packets delivery info")
>>>
>>> Tested:
>>>
>>> ss -ti
>>> ...
>>> ESTAB   0 2270520      [2607:f8b0:8099:e16::]:47646   [2607:f8b0:8099:e18::]:38953
>>> 	 ts sack cubic wscale:8,8 rto:7 rtt:2.824/0.278 mss:1428
>>>      pmtu:1500 rcvmss:536 advmss:1428 cwnd:89 ssthresh:62 bytes_acked:2097871945
>>>     segs_out:1469144 segs_in:65221 data_segs_out:1469142 send 360.0Mbps lastsnd:2
>>>     lastrcv:99231 lastack:2 pacing_rate 431.9Mbps delivery_rate 246.4Mbps
>>> (*) delivered:1469099 delivered_ce:424799
>>>     busy:99231ms unacked:44 rcv_space:14280 rcv_ssthresh:65535
>>>     notsent:2207688 minrtt:0.228
>>>
>>> Signed-off-by: Eric Dumazet <edumazet@...gle.com>
>>
>> Applied
>>
> 
> Thanks Stephen
> 
> BTW, it seems ss had some recent regression :
> 
> Old ss command was happy with "ss dst 127.0.0.1 and not dst :12865"
> 
> But current one is not.
> 
> root@...mazet-glaptop:/usr/src/iproute2# ss -V
> ss utility, iproute2-ss171113
> 
> root@...mazet-glaptop:/usr/src/iproute2# ss dst 127.0.0.1 and not dst :12865
> Netid  State      Recv-Q Send-Q                        Local Address:Port                                         Peer Address:Port                
> tcp    ESTAB      0      0                                 127.0.0.1:45368                                           127.0.0.1:999                  
> tcp    ESTAB      0      0                                 127.0.0.1:999                                             127.0.0.1:45368   
> 
>              
> root@...mazet-glaptop:/usr/src/iproute2# misc/ss -V
> ss utility, iproute2-ss181023
> 
> root@...mazet-glaptop:/usr/src/iproute2# misc/ss dst 127.0.0.1 and not dst :12865
> ss: bison bellows (while parsing filter): "syntax error!" Sorry.
> Usage: ss [ OPTIONS ]
>        ss [ OPTIONS ] [ FILTER ]
> ...
> 

Most logical commit to ssfilter.y is:

commit 38d209ecf2ae966b9b25de4acb60cdffb0e06ced
Author: Phil Sutter <phil@....cc>
Date:   Tue Aug 14 14:18:06 2018 +0200

    ss: Review ssfilter

Can you revert it and see if it helps?