netdev - Re: [PATCH] net: usb: aqc111: Properly initialize wol_cfg in aqc111

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20181129055440.GA2882@flashbox>
Date:   Wed, 28 Nov 2018 22:54:40 -0700
From:   Nathan Chancellor <natechancellor@...il.com>
To:     David Miller <davem@...emloft.net>
Cc:     dmitry.bezrukov@...antia.com, igor.russkikh@...antia.com,
        netdev@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] net: usb: aqc111: Properly initialize wol_cfg in
 aqc111_suspend

On Wed, Nov 28, 2018 at 09:52:41PM -0800, David Miller wrote:
> From: Nathan Chancellor <natechancellor@...il.com>
> Date: Wed, 28 Nov 2018 22:18:09 -0700
> 
> > Clang warns:
> > 
> > drivers/net/usb/aqc111.c:1326:37: warning: suggest braces around
> > initialization of subobject [-Wmissing-braces]
> >                 struct aqc111_wol_cfg wol_cfg = { 0 };
> >                                                   ^
> >                                                   {}
> > 1 warning generated.
> > 
> > Add another set of braces to initialize the char subobjects as well.
> > 
> > Fixes: e58ba4544c77 ("net: usb: aqc111: Add support for wake on LAN by MAGIC packet")
> > Signed-off-by: Nathan Chancellor <natechancellor@...il.com>
> 
> This will in turn make some versions of gcc warn.
> 
> Please just memset() this object, thanks.

I thought this was the form that all compilers seemed to agree on but
sure, I will send a v2.

Thanks for the quick response,
Nathan