netdev - [PATCH iproute2] l2tp: Fix printing of cookie and peer

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [day] [month] [year] [list]

Message-Id: <000a6802b08986b9e056a8f66784eadf7226eed5.1543588086.git.aclaudi@redhat.com>
Date:   Fri, 30 Nov 2018 15:34:24 +0100
From:   Andrea Claudi <aclaudi@...hat.com>
To:     dsahern@...il.com, stephen@...workplumber.org
Cc:     netdev@...r.kernel.org
Subject: [PATCH iproute2] l2tp: Fix printing of cookie and peer_cookie values

print_cookie() invocations miss %s format specifier.
While at it, align printout to the previous lines.

Fixes: 98453b65800f7 ("ip/l2tp: add JSON support")
Signed-off-by: Andrea Claudi <aclaudi@...hat.com>
---
 ip/ipl2tp.c | 5 +++--
 1 file changed, 3 insertions(+), 2 deletions(-)

diff --git a/ip/ipl2tp.c b/ip/ipl2tp.c
index 4308b591..f699b258 100644
--- a/ip/ipl2tp.c
+++ b/ip/ipl2tp.c
@@ -302,10 +302,11 @@ static void print_session(struct l2tp_data *data)
 	print_uint(PRINT_FP, "peer_offset", " peer offset %u\n", 0);
 
 	if (p->cookie_len > 0)
-		print_cookie("cookie", "cookie",
+		print_cookie("cookie", "  cookie %s",
 			     p->cookie, p->cookie_len);
+
 	if (p->peer_cookie_len > 0)
-		print_cookie("peer_cookie", "peer cookie",
+		print_cookie("peer_cookie", "  peer cookie %s",
 			     p->peer_cookie, p->peer_cookie_len);
 
 	if (p->reorder_timeout != 0)
-- 
2.19.2