netdev - Re: [PATCH net] rtnetlink: Refine sanity checks in rtnl_fdb

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Fri, 30 Nov 2018 07:46:28 -0800
From:   Eric Dumazet <edumazet@...gle.com>
To:     David Ahern <dsahern@...il.com>
Cc:     Ido Schimmel <idosch@...sch.org>,
        David Miller <davem@...emloft.net>,
        netdev <netdev@...r.kernel.org>,
        Eric Dumazet <eric.dumazet@...il.com>,
        syzkaller@...glegroups.com, idosch@...lanox.com
Subject: Re: [PATCH net] rtnetlink: Refine sanity checks in rtnl_fdb_{add|del}

On Fri, Nov 30, 2018 at 7:40 AM Eric Dumazet <edumazet@...gle.com> wrote:
>
> On Fri, Nov 30, 2018 at 7:36 AM David Ahern <dsahern@...il.com> wrote:
> >
> > On 11/30/18 7:58 AM, Ido Schimmel wrote:
> > > Can you please share the reproducer (assuming it exists)? I don't really
> > > understand the fix. None of the functions you patched are in the trace.
> > > Also, looking at IPv4 GRE code, while GRE device has dev->addr_len set
> > > to 4, dev->type is set to ARPHRD_IPGRE.
> >
> > I had the same reaction ... you can not claim to be an ethernet device
> > and have a hw address that is not 6 bytes.
>
> This has been discussed a number of times.... TUNSETLINK can do that.
> (I have not checked what the repro does )


Oh well...ndo_dflt_fdb_dump() seems to be used on a gre device.