netdev - Re: [PATCH 3/3] dt-bindings: net: dsa: add new bindings MT7530

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <6d031e8f-17cd-cf64-9d05-a5b48bf448a7@gmail.com>
Date:   Fri, 30 Nov 2018 09:41:47 -0800
From:   Florian Fainelli <f.fainelli@...il.com>
To:     gerg@...nel.org, sean.wang@...iatek.com, andrew@...n.ch,
        vivien.didelot@...oirfairelinux.com, netdev@...r.kernel.org
Cc:     blogic@...nwrt.org, neil@...wn.name
Subject: Re: [PATCH 3/3] dt-bindings: net: dsa: add new bindings MT7530

Hi Greg,

On 11/29/2018 11:57 PM, gerg@...nel.org wrote:
> From: Greg Ungerer <gerg@...nel.org>
> 
> Add descriptive entries for the new bindings introduced to support the
> MT7530 implementation in the MediaTek MT7621 SoC.
> 
> New bindings added for:
> 
>   mediatek,no-clock-regulator
>   mediatek,mfc-has-cpuport

I don't think any of these properties are necessary, if you can either
use a compatible string, and/or infer the actual model at runtime in the
driver's probe function, then you can assess based on that chip model as
well as the properties being provided in Device Tree whether these
resources must be grabbed and used. See mv88e6xxx and b53 for how these
drivers deal with supporting several distinct models within the same
code base.

As far as the MFC programming goes, this is definitively something that
must be done once you know the chip model you are dealing with.
-- 
Florian