netdev - Re: [PATCH] net: tcp: add correct check for tcp_retransmit

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20dde5c1-959e-c14b-9640-82f96e29ff76@gmail.com>
Date:   Fri, 30 Nov 2018 10:40:39 -0800
From:   Eric Dumazet <eric.dumazet@...il.com>
To:     Sharath Chandra Vurukala <sharathv@...eaurora.org>,
        netdev@...r.kernel.org
Cc:     chinagar@...eaurora.org, kapandey@...eaurora.org,
        subashab@...eaurora.org
Subject: Re: [PATCH] net: tcp: add correct check for tcp_retransmit_skb()



On 11/30/2018 10:28 AM, Sharath Chandra Vurukala wrote:
> when the tcp_retranmission_timer expires and tcp_retranmsit_skb is
> called if the retranmsission fails due to local congestion,
> backoff should not incremented.
> 
> tcp_retransmit_skb() returns non-zero negative value in some cases of
> failure but the caller tcp_retransmission_timer() has a check for
> failure which checks if the return value is greater than zero.
> The check is corrected to check for non-zero value.
> 
> Signed-off-by: Sharath Chandra Vurukala <sharathv@...eaurora.org>
>

This looks wrong.

Yuchung has cooked a patch series to really address issues, please wait for it

We are waiting for David Miller to merge a prior patch series into net tree, then
in net-next.

Thanks.