netdev - Re: [PATCH net] net: aquantia: fix rx checksum offload bits

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20181130.132016.446917177184295586.davem@davemloft.net>
Date:   Fri, 30 Nov 2018 13:20:16 -0800 (PST)
From:   David Miller <davem@...emloft.net>
To:     Igor.Russkikh@...antia.com
Cc:     netdev@...r.kernel.org, Dmitry.Bogdanov@...antia.com
Subject: Re: [PATCH net] net: aquantia: fix rx checksum offload bits

From: Igor Russkikh <Igor.Russkikh@...antia.com>
Date: Tue, 27 Nov 2018 14:51:17 +0000

> From: Dmitry Bogdanov <dmitry.bogdanov@...antia.com>
> 
> The last set of csum offload fixes had a leak:
> 
> Checksum enabled status bits from rx descriptor were incorrectly
> interpreted. Consequently all the other valid logic worked on zero bits.
> That caused rx checksum offloads never to trigger.
> 
> Tested by dumping rx descriptors and validating resulting csum_level.
> 
> Reported-by: Igor Russkikh <igor.russkikh@...antia.com>
> Signed-off-by: Dmitry Bogdanov <dmitry.bogdanov@...antia.com>
> Signed-off-by: Igor Russkikh <igor.russkikh@...antia.com>
> Fixes: ad703c2b9127f ("net: aquantia: invalid checksumm offload implementation")

Applied.

This shows that the feature added was not actually tested.

Thanks.