netdev - Re: [PATCH 3/8] socket: Disentangle SOCK_RCVTSTAMPNS from SOCK

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CABeXuvp6tBvuHu94H3qHkhu48KXadRwZ_3aNZn0_fEjZyXsnvQ@mail.gmail.com>
Date:   Fri, 30 Nov 2018 14:16:21 -0800
From:   Deepa Dinamani <deepa.kernel@...il.com>
To:     "David S. Miller" <davem@...emloft.net>
Cc:     willemdebruijn.kernel@...il.com,
        Linux Kernel Mailing List <linux-kernel@...r.kernel.org>,
        Linux Network Devel Mailing List <netdev@...r.kernel.org>,
        Alexander Viro <viro@...iv.linux.org.uk>,
        Arnd Bergmann <arnd@...db.de>,
        y2038 Mailman List <y2038@...ts.linaro.org>
Subject: Re: [PATCH 3/8] socket: Disentangle SOCK_RCVTSTAMPNS from SOCK_RCVTSTAMP

On Sun, Nov 25, 2018 at 10:19 AM David Miller <davem@...emloft.net> wrote:
>
> From: Willem de Bruijn <willemdebruijn.kernel@...il.com>
> Date: Sun, 25 Nov 2018 09:18:55 -0500
>
> > The existing logic is as is for a reason. There is no need to change
> > it to satisfy the main purpose of your patchset?
> >
> > It is structured as one bit to test whether a timestamp is requested
> > and another to select among two variants usec/nsec. Just add another
> > layer of branching between new/old in cases where this distinction is
> > needed.
> >
> > Please avoid code churn unless needed.
>
> +1

This patch makes it easier to add logic for 2 new socket time options.
But, if you prefer for all of the options to depend on SOCK_RCVTSTAMP
then I will drop it.

-Deepa