netdev - Re: [PATCHv3 bpf 1/2] bpf: Support sk lookup in netns with id 0

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20181201012027.huph7f5wbvref3di@gmail.com>
Date:   Fri, 30 Nov 2018 15:20:27 -1000
From:   Joey Pabalinas <joeypabalinas@...il.com>
To:     Joey Pabalinas <joeypabalinas@...il.com>,
        Joe Stringer <joe@...d.net.nz>, daniel@...earbox.net,
        ast@...nel.org, netdev@...r.kernel.org, dsahern@...il.com,
        nicolas.dichtel@...nd.com
Subject: Re: [PATCHv3 bpf 1/2] bpf: Support sk lookup in netns with id 0

On Fri, Nov 30, 2018 at 02:36:57PM -1000, Joey Pabalinas wrote:
> On Fri, Nov 30, 2018 at 03:32:20PM -0800, Joe Stringer wrote:
> > + *		the netns associated with the *ctx*. *netns* values beyond the
> > + *		range of 32-bit integers are reserved for future use.
> 
> Would adding a word or two before "*netns*" here be helpful to placate
> the english pedants among us (such as myself)? Starting a sentence with
> a lowercase word, even if it's a variable name, just never really sits
> right with me.
> 
> 	Any *netns* values ...
> 
> Doesn't that kind of flow a bit better anyway?

Hah,

> Anyway, now with that unimportant nitpick if off my chest, the rest
                                            ^
                                            |
I make an absolutely terrible pedant. ------

-- 
Cheers,
Joey Pabalinas

Download attachment "signature.asc" of type "application/pgp-signature" (834 bytes)