netdev - Re: [PATCH net] tun: forbid iface creation with rtnl ops

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20181130.173208.2286609054745079606.davem@davemloft.net>
Date:   Fri, 30 Nov 2018 17:32:08 -0800 (PST)
From:   David Miller <davem@...emloft.net>
To:     nicolas.dichtel@...nd.com
Cc:     netdev@...r.kernel.org, ebiederm@...ssion.com
Subject: Re: [PATCH net] tun: forbid iface creation with rtnl ops

From: Nicolas Dichtel <nicolas.dichtel@...nd.com>
Date: Thu, 29 Nov 2018 14:45:39 +0100

> It's not supported right now (the goal of the initial patch was to support
> 'ip link del' only).
> 
> Before the patch:
> $ ip link add foo type tun
> [  239.632660] BUG: unable to handle kernel NULL pointer dereference at 0000000000000000
> [snip]
> [  239.636410] RIP: 0010:register_netdevice+0x8e/0x3a0
> 
> This panic occurs because dev->netdev_ops is not set by tun_setup(). But to
> have something usable, it will require more than just setting
> netdev_ops.
> 
> Fixes: f019a7a594d9 ("tun: Implement ip link del tunXXX")
> CC: Eric W. Biederman <ebiederm@...ssion.com>
> Signed-off-by: Nicolas Dichtel <nicolas.dichtel@...nd.com>

Super old bug, scary.

Applied, thanks.