netdev - Re: [PATCH] net/core: tidy up an error message

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <fc4e1657b33a532b2e970e4b319d0ab5375a1355.camel@perches.com>
Date:   Sat, 01 Dec 2018 06:43:40 -0800
From:   Joe Perches <joe@...ches.com>
To:     Qian Cai <cai@....us>, davem@...emloft.net
Cc:     yisen.zhuang@...wei.com, salil.mehta@...wei.com,
        netdev@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] net/core: tidy up an error message

On Fri, 2018-11-30 at 23:51 -0500, Qian Cai wrote:
> netif_napi_add() could report an error like this below due to it allows
> to pass a format string for wildcarding before calling
> dev_get_valid_name(),
> 
> "netif_napi_add() called with weight 256 on device eth%d"
> 
> For example, hns_enet_drv module does this.
> 
> hns_nic_try_get_ae
>   hns_nic_init_ring_data
>     netif_napi_add
>   register_netdev
>     dev_get_valid_name
> 
> Hence, make it a bit more human-readable.
[]
> diff --git a/net/core/dev.c b/net/core/dev.c
[]
> @@ -6205,7 +6205,8 @@ void netif_napi_add(struct net_device *dev, struct napi_struct *napi,
>  	napi->poll = poll;
>  	if (weight > NAPI_POLL_WEIGHT)
>  		pr_err_once("netif_napi_add() called with weight %d on device %s\n",
> -			    weight, dev->name);
> +			    weight,
> +			    !strchr(dev->name, '%') ? dev->name : "unknown");

perhaps instead use netdev_err_once