netdev - Re: [PATCHv3 bpf 1/2] bpf: Support sk lookup in netns with id 0

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CAOftzPjG4WJO-ntK7oij4G7qzwmag=qikbOrMHeSn86Bex0-Cg@mail.gmail.com>
Date:   Sat, 1 Dec 2018 09:18:12 -0800
From:   Joe Stringer <joe@...d.net.nz>
To:     Alexei Starovoitov <alexei.starovoitov@...il.com>
Cc:     Joe Stringer <joe@...d.net.nz>, daniel@...earbox.net,
        ast@...nel.org, netdev <netdev@...r.kernel.org>,
        David Ahern <dsahern@...il.com>,
        Nicolas Dichtel <nicolas.dichtel@...nd.com>
Subject: Re: [PATCHv3 bpf 1/2] bpf: Support sk lookup in netns with id 0

On Fri, 30 Nov 2018 at 17:36, Alexei Starovoitov
<alexei.starovoitov@...il.com> wrote:
>
> On Fri, Nov 30, 2018 at 03:32:20PM -0800, Joe Stringer wrote:
> > David Ahern and Nicolas Dichtel report that the handling of the netns id
> > 0 is incorrect for the BPF socket lookup helpers: rather than finding
> > the netns with id 0, it is resolving to the current netns. This renders
> > the netns_id 0 inaccessible.
> >
> > To fix this, adjust the API for the netns to treat all negative s32
> > values as a lookup in the current netns (including u64 values which when
> > truncated to s32 become negative), while any values with a positive
> > value in the signed 32-bit integer space would result in a lookup for a
> > socket in the netns corresponding to that id. As before, if the netns
> > with that ID does not exist, no socket will be found. Any netns outside
> > of these ranges will fail to find a corresponding socket, as those
> > values are reserved for future usage.
> >
> > Signed-off-by: Joe Stringer <joe@...d.net.nz>
> > Acked-by: Nicolas Dichtel <nicolas.dichtel@...nd.com>
>
> Applied both. Thanks everyone.
>
> Joe, please provide a cover letter 0/N next time for the series
> or if they're really separate patches submit them one by one.

OK thanks, I'll keep that in mind.