netdev - Re: [PATCH v1 net-next 02/14] octeontx2-af: Add response for RSS flow key cfg message

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Sat, 01 Dec 2018 17:30:36 -0800 (PST)
From:   David Miller <davem@...emloft.net>
To:     jerinjacobk@...il.com
Cc:     netdev@...r.kernel.org, sgoutham@...vell.com, lcherian@...vell.com,
        gakula@...vell.com, jerinj@...vell.com
Subject: Re: [PATCH v1 net-next 02/14] octeontx2-af: Add response for RSS
 flow key cfg message

From: Jerin Jacob <jerinjacobk@...il.com>
Date: Sat,  1 Dec 2018 14:43:51 +0530

> +#define FLOW_KEY_TYPE_PORT	BIT(0)
> +#define FLOW_KEY_TYPE_IPV4	BIT(1)
> +#define FLOW_KEY_TYPE_IPV6	BIT(2)
> +#define FLOW_KEY_TYPE_TCP	BIT(3)
> +#define FLOW_KEY_TYPE_UDP	BIT(4)
> +#define FLOW_KEY_TYPE_SCTP	BIT(5)

This is asking for serious global namespace collisions, as we have
various FLOW_* definitions coming from include/uapi/linux/pkt_cls.h
for example.

Please put some appropriate driver prefix to these macro names.

Thanks.