netdev - Re: [PATCH v2 0/2] net: phy: micrel: add tobling phy reset

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20181203.152057.61263535375452379.davem@davemloft.net>
Date:   Mon, 03 Dec 2018 15:20:57 -0800 (PST)
From:   David Miller <davem@...emloft.net>
To:     yoshihiro.shimoda.uh@...esas.com
Cc:     andrew@...n.ch, f.fainelli@...il.com, netdev@...r.kernel.org,
        linux-renesas-soc@...r.kernel.org, devicetree@...r.kernel.org
Subject: Re: [PATCH v2 0/2] net: phy: micrel: add tobling phy reset

From: Yoshihiro Shimoda <yoshihiro.shimoda.uh@...esas.com>
Date: Wed, 28 Nov 2018 09:02:41 +0000

> This patch set is for R-Car Gen3 Salvator-XS boards. If we do
> the following method, the phy cannot link up correctly.
> 
>  1) Kernel boots by using initramfs.
>  --> No open the nic, so phy_device_register() and phy_probe()
>      deasserts the reset.
>  2) Kernel enters the suspend.
>  --> So, keep the reset signal as deassert.
>  --> On R-Car Salvator-XS board, unfortunately, the board power is
>      turned off.
>  3) Kernel returns from suspend.
>  4) ifconfig eth0 up
>  --> Then, since edge signal of the reset doesn't happen,
>      it cannot link up.
>  5) ifconfig eth0 down
>  6) ifconfig eth0 up
>  --> In this case, it can link up.
> 
> When resolving this issue after I got feedback from Andrew and Heiner,
> I found an issue that the phy_device.c didn't call phy_resume()
> if the PHY was not attached. So, patch 1 fixes it and add toggling
> the phy reset to the micrel phy driver.
> 
> Changes from v1 (as RFC):
>  - No remove the current code of phy_device.c to avoid any side effects.
>  - Fix the mdio_bus_phy_resume() in phy_device.c.
>  - Add toggling the phy reset in micrel.c if the PHY is not attached.

Series applied, thank you.