netdev - Re: [PATCH net] net/ibmvnic: Fix RTNL deadlock during device reset

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20181203.155407.1991361246046779906.davem@davemloft.net>
Date:   Mon, 03 Dec 2018 15:54:07 -0800 (PST)
From:   David Miller <davem@...emloft.net>
To:     tlfalcon@...ux.ibm.com
Cc:     netdev@...r.kernel.org
Subject: Re: [PATCH net] net/ibmvnic: Fix RTNL deadlock during device reset

From: Thomas Falcon <tlfalcon@...ux.ibm.com>
Date: Fri, 30 Nov 2018 10:59:08 -0600

> Commit a5681e20b541 ("net/ibmnvic: Fix deadlock problem
> in reset") made the change to hold the RTNL lock during
> driver reset but still calls netdev_notify_peers, which
> results in a deadlock. Instead, use call_netdevice_notifiers,
> which is functionally the same except that it does not
> take the RTNL lock again.
> 
> Fixes: a5681e20b541 ("net/ibmnvic: Fix deadlock problem in reset")
> 
> Signed-off-by: Thomas Falcon <tlfalcon@...ux.ibm.com>

Applied.