netdev - Re: [PATCH 0/3] net: macb: DMA race condition fixes

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <363e3baa-ca57-87e9-0a74-c24d7654da4c@microchip.com>
Date:   Mon, 3 Dec 2018 08:26:52 +0000
From:   <Nicolas.Ferre@...rochip.com>
To:     <anssi.hannula@...wise.fi>, <davem@...emloft.net>,
        <Claudiu.Beznea@...rochip.com>
CC:     <netdev@...r.kernel.org>
Subject: Re: [PATCH 0/3] net: macb: DMA race condition fixes

On 30/11/2018 at 19:21, Anssi Hannula wrote:
> Hi all,
> 
> Here are a couple of race condition fixes for the macb driver. The first
> two are issues observed on real HW.
> 
> Anssi Hannula (3):
>        net: macb: fix random memory corruption on RX with 64-bit DMA
>        net: macb: fix dropped RX frames due to a race
>        net: macb: add missing barriers when reading buffers
> 
>   drivers/net/ethernet/cadence/macb_main.c | 34 +++++++++++++++++++++-----
>   1 file changed, 28 insertions(+), 6 deletions(-)

David,

Can you please delay a bit the acceptance of this series, I would like 
that we assess these findings with tests on our hardware before applying 
them.

Anssi,

Thanks a lot for this series. On our side, we have one pending patch 
about fixing a race condition on our hardware. We would need to redo 
some tests with our patch and yours so that we know better the behavior 
of our hardware.

Best regards,
-- 
Nicolas Ferre