netdev - [PATCH iproute2 v3] iproute2: Installation errors without libmnl

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [thread-next>] [day] [month] [year] [list]

Date:   Mon,  3 Dec 2018 12:13:06 +0100
From:   Emeric Dupont <emeric.dupont@....aero>
To:     netdev@...r.kernel.org
Cc:     Emeric Dupont <emeric.dupont@....aero>
Subject: [PATCH iproute2 v3] iproute2: Installation errors without libmnl

When performing make install in iproute2 (current git master),
     if $(HAVE_MNL) is not selected, some Makefiles try to call
     install with an empty target, which causes a non-critical make error.

Signed-off-by: Emeric Dupont <emeric.dupont@....aero>
---
 devlink/Makefile | 4 +++-
 rdma/Makefile    | 4 +++-
 tipc/Makefile    | 4 +++-
 3 files changed, 9 insertions(+), 3 deletions(-)

diff --git a/devlink/Makefile b/devlink/Makefile
index ace34c7b..9cc4888d 100644
--- a/devlink/Makefile
+++ b/devlink/Makefile
@@ -19,7 +19,9 @@ devlink: $(DEVLINKOBJ)
 	$(QUIET_LINK)$(CC) $^ $(LDFLAGS) $(LDLIBS) -o $@
 
 install: all
-	install -m 0755 $(TARGETS) $(DESTDIR)$(SBINDIR)
+	for i in $(TARGETS); \
+	do install -m 0755 $$i $(DESTDIR)$(SBINDIR); \
+	done
 
 clean:
 	rm -f $(DEVLINKOBJ) $(TARGETS)
diff --git a/rdma/Makefile b/rdma/Makefile
index 819fcbe3..0498994f 100644
--- a/rdma/Makefile
+++ b/rdma/Makefile
@@ -17,7 +17,9 @@ rdma:	$(RDMA_OBJ) $(LIBS)
 	$(QUIET_LINK)$(CC) $^ $(LDFLAGS) $(LDLIBS) -o $@
 
 install: all
-	install -m 0755 $(TARGETS) $(DESTDIR)$(SBINDIR)
+	for i in $(TARGETS); \
+	do install -m 0755 $$i $(DESTDIR)$(SBINDIR); \
+	done
 
 clean:
 	rm -f $(RDMA_OBJ) $(TARGETS)
diff --git a/tipc/Makefile b/tipc/Makefile
index fdb18d39..a10debe0 100644
--- a/tipc/Makefile
+++ b/tipc/Makefile
@@ -22,7 +22,9 @@ tipc: $(TIPCOBJ)
 	$(QUIET_LINK)$(CC) $^ $(LDFLAGS) $(LDLIBS) -o $@
 
 install: all
-	install -m 0755 $(TARGETS) $(DESTDIR)$(SBINDIR)
+	for i in $(TARGETS); \
+	do install -m 0755 $$i $(DESTDIR)$(SBINDIR); \
+	done
 
 clean:
 	rm -f $(TIPCOBJ) $(TARGETS)
-- 
2.19.2