netdev - Re: [PATCH 0/3]: net: dsa: mt7530: support MT7530 in the MT7621 SoC

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <3c07dbef-8e7c-8e4f-e13f-e40099e55570@phrozen.org>
Date:   Mon, 3 Dec 2018 15:02:32 +0100
From:   John Crispin <john@...ozen.org>
To:     René van Dorst <opensource@...rst.com>,
        Bjørn Mork <bjorn@...k.no>
Cc:     Greg Ungerer <gerg@...nel.org>, sean.wang@...iatek.com,
        andrew@...n.ch, vivien.didelot@...oirfairelinux.com,
        f.fainelli@...il.com, netdev@...r.kernel.org, neil@...wn.name
Subject: Re: [PATCH 0/3]: net: dsa: mt7530: support MT7530 in the MT7621 SoC


On 03/12/2018 15:00, René van Dorst wrote:
> Quoting Bjørn Mork <bjorn@...k.no>:
>> Greg Ungerer <gerg@...nel.org> writes:
>>
>>> The following change helped alot, but I still get some problems under
>>> sustained load and some types of port setups. Still trying to figure
>>> out what exactly is going on.
>>>
>>> --- a/linux/drivers/net/ethernet/mediatek/mtk_eth_soc.c
>>> +++ b/linux/drivers/net/ethernet/mediatek/mtk_eth_soc.c
>>> @@ -1750,8 +1750,8 @@ static irqreturn_t mtk_handle_irq_rx(int irq, 
>>> void *_eth)
>>>        if (likely(napi_schedule_prep(&eth->rx_napi))) {
>>>                 __napi_schedule(&eth->rx_napi);
>>> -               mtk_rx_irq_disable(eth, MTK_RX_DONE_INT);
>>>         }
>>> +       mtk_rx_irq_disable(eth, MTK_RX_DONE_INT);
>>>        return IRQ_HANDLED;
>>>  }
>>> @@ -1762,11 +1762,53 @@ static irqreturn_t mtk_handle_irq_tx(int 
>>> irq, void *_eth)
>>>        if (likely(napi_schedule_prep(&eth->tx_napi))) {
>>>                 __napi_schedule(&eth->tx_napi);
>>> -               mtk_tx_irq_disable(eth, MTK_TX_DONE_INT);
>>>         }
>>> +       mtk_tx_irq_disable(eth, MTK_TX_DONE_INT);
>>>        return IRQ_HANDLED;
>>>  }
>>
>> Yes, sorry I didn't point to that as well.  Just to be clear:  I have no
>> clue how this thing is actually wired up, or if you could use three
>> interrupts on the MT7621 too. I just messed with it until I got
>> something to work, based on Renés original idea and code.
>
> My idea is a just a copy of mtk_handle_irq_{rx,tx} see [1]
> You probably want to look at the staging driver or Ubiquity source 
> with a 3.10.x kernel [2] or padavan with 3.4.x kernel [3].
> AFAIK mt7621 only has 1 IRQ for ethernet part.

correct there is only 1 single IRQ on mt7621

     John



>
> Greats,
>
> René
>
> [1] 
> https://git.kernel.org/pub/scm/linux/kernel/git/stable/linux.git/tree/drivers/net/ethernet/mediatek/mtk_eth_soc.c#n1739
> [2] 
> https://www.ubnt.com/download/edgemax/edgerouter-x-sfp/default/edgerouter-er-xer-x-sfpep-r6-firmware-v1107
> [3] 
> https://bitbucket.org/padavan/rt-n56u/src/e6f45337528f668651e251057a1a0fec735f6df1/trunk/linux-3.4.x/drivers/net/raeth/raether.c?at=master&fileviewer=file-view-default#raether.c-658
>
>