netdev - Re: [PATCH net-next] net: netem: use a list in addition to rbtree

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <3d74a813-326b-43dd-0a05-d637cae5c0fd@gmail.com>
Date:   Tue, 4 Dec 2018 07:57:15 -0800
From:   Eric Dumazet <eric.dumazet@...il.com>
To:     Peter Oskolkov <posk@...gle.com>,
        David Miller <davem@...emloft.net>, netdev@...r.kernel.org
Cc:     Peter Oskolkov <posk.devel@...il.com>,
        Eric Dumazet <edumazet@...gle.com>
Subject: Re: [PATCH net-next] net: netem: use a list in addition to rbtree



On 12/03/2018 05:07 PM, Peter Oskolkov wrote:
> When testing high-bandwidth TCP streams with large windows,
> high latency, and low jitter, netem consumes a lot of CPU cycles
> doing rbtree rebalancing.
> 
> This patch uses a linear list/queue in addition to the rbtree:
> if an incoming packet is past the tail of the linear queue, it is
> added there, otherwise it is inserted into the rbtree.
> 
> Without this patch, perf shows netem_enqueue, netem_dequeue,
> and rb_* functions among the top offenders. With this patch,
> only netem_enqueue is noticeable if jitter is low/absent.
> 
> Suggested-by: Eric Dumazet <edumazet@...gle.com>
> Signed-off-by: Peter Oskolkov <posk@...gle.com>
> ---

Reviewed-by: Eric Dumazet <edumazet@...gle.com>

Thanks Peter !