netdev - Re: [PATCH v2] net/core: tidy up an error message

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20181203.161514.1229179839092578403.davem@davemloft.net>
Date:   Mon, 03 Dec 2018 16:15:14 -0800 (PST)
From:   David Miller <davem@...emloft.net>
To:     cai@....us
Cc:     yisen.zhuang@...wei.com, salil.mehta@...wei.com, joe@...ches.com,
        stephen@...workplumber.org, netdev@...r.kernel.org,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH v2] net/core: tidy up an error message

From: Qian Cai <cai@....us>
Date: Sat,  1 Dec 2018 21:11:19 -0500

> netif_napi_add() could report an error like this below due to it allows
> to pass a format string for wildcarding before calling
> dev_get_valid_name(),
> 
> "netif_napi_add() called with weight 256 on device eth%d"
> 
> For example, hns_enet_drv module does this.
> 
> hns_nic_try_get_ae
>   hns_nic_init_ring_data
>     netif_napi_add
>   register_netdev
>     dev_get_valid_name
> 
> Hence, make it a bit more human-readable by using netdev_err_once()
> instead.
> 
> Signed-off-by: Qian Cai <cai@....us>

Applied, thanks.