netdev - Re: [Patch net] mlx5: check for malformed packets

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CALzJLG9U_pcEyXxjCqD5eVqf+sh4A1OUZfasqK3sDHFPr2seyg@mail.gmail.com>
Date:   Tue, 4 Dec 2018 11:28:30 -0800
From:   Saeed Mahameed <saeedm@....mellanox.co.il>
To:     Cong Wang <xiyou.wangcong@...il.com>
Cc:     Linux Netdev List <netdev@...r.kernel.org>,
        Tariq Toukan <tariqt@...lanox.com>,
        Saeed Mahameed <saeedm@...lanox.com>
Subject: Re: [Patch net] mlx5: check for malformed packets

On Mon, Dec 3, 2018 at 10:39 AM Cong Wang <xiyou.wangcong@...il.com> wrote:
>
> On Sat, Dec 1, 2018 at 12:38 PM Cong Wang <xiyou.wangcong@...il.com> wrote:
> >
> > is_last_ethertype_ip() is used to check IP/IPv6 protocol before
> > parsing IP/IPv6 headers.
>
> One thing I noticed while reviewing the assembly code is that
> is_last_ethertype_ip() is no longer inlined after this patch.
>
> I think I should keep it inlined by using __always_inline, as it is on
> a hot path.
>
> What do you think, Tariq?

We are against having inline keywords in c file,  so better if you
move this function to a header file an force the inline keyword there.