netdev - [tip:core/rcu] sfc: Replace spin_is

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [day] [month] [year] [list]

Date:   Tue, 4 Dec 2018 14:33:45 -0800
From:   tip-bot for Lance Roy <tipbot@...or.com>
To:     linux-tip-commits@...r.kernel.org
Cc:     paulmck@...ux.ibm.com, linux-net-drivers@...arflare.com,
        ecree@...arflare.com, mingo@...nel.org, tglx@...utronix.de,
        ldr709@...il.com, davem@...emloft.net, netdev@...r.kernel.org,
        hpa@...or.com, bkenward@...arflare.com
Subject: [tip:core/rcu] sfc: Replace spin_is_locked() with lockdep

Commit-ID:  013ff4a6e7bc5aa64b0b937daae0244e3c93e49c
Gitweb:     https://git.kernel.org/tip/013ff4a6e7bc5aa64b0b937daae0244e3c93e49c
Author:     Lance Roy <ldr709@...il.com>
AuthorDate: Thu, 4 Oct 2018 23:45:41 -0700
Committer:  Paul E. McKenney <paulmck@...ux.ibm.com>
CommitDate: Mon, 12 Nov 2018 09:06:22 -0800

sfc: Replace spin_is_locked() with lockdep

lockdep_assert_held() is better suited to checking locking requirements,
since it only checks if the current thread holds the lock regardless of
whether someone else does. This is also a step towards possibly removing
spin_is_locked().

Signed-off-by: Lance Roy <ldr709@...il.com>
Cc: Solarflare linux maintainers <linux-net-drivers@...arflare.com>
Cc: Bert Kenward <bkenward@...arflare.com>
Cc: "David S. Miller" <davem@...emloft.net>
Cc: <netdev@...r.kernel.org>
Signed-off-by: Paul E. McKenney <paulmck@...ux.ibm.com>
Acked-by: Edward Cree <ecree@...arflare.com>
---
 drivers/net/ethernet/sfc/efx.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/net/ethernet/sfc/efx.c b/drivers/net/ethernet/sfc/efx.c
index 98fe7e762e17..3643015a55cf 100644
--- a/drivers/net/ethernet/sfc/efx.c
+++ b/drivers/net/ethernet/sfc/efx.c
@@ -3167,7 +3167,7 @@ struct hlist_head *efx_rps_hash_bucket(struct efx_nic *efx,
 {
 	u32 hash = efx_filter_spec_hash(spec);
 
-	WARN_ON(!spin_is_locked(&efx->rps_hash_lock));
+	lockdep_assert_held(&efx->rps_hash_lock);
 	if (!efx->rps_hash_table)
 		return NULL;
 	return &efx->rps_hash_table[hash % EFX_ARFS_HASH_TABLE_SIZE];