netdev - [tip:core/rcu] smsc: Replace spin_is

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [day] [month] [year] [list]

Message-ID: <tip-97eeebea894283c290ead6694b76f575e7654773@git.kernel.org>
Date:   Tue, 4 Dec 2018 14:34:19 -0800
From:   tip-bot for Lance Roy <tipbot@...or.com>
To:     linux-tip-commits@...r.kernel.org
Cc:     tglx@...utronix.de, paulmck@...ux.ibm.com, hpa@...or.com,
        netdev@...r.kernel.org, steve.glendinning@...well.net,
        ldr709@...il.com, davem@...emloft.net, mingo@...nel.org
Subject: [tip:core/rcu] smsc: Replace spin_is_locked() with lockdep

Commit-ID:  97eeebea894283c290ead6694b76f575e7654773
Gitweb:     https://git.kernel.org/tip/97eeebea894283c290ead6694b76f575e7654773
Author:     Lance Roy <ldr709@...il.com>
AuthorDate: Thu, 4 Oct 2018 23:45:42 -0700
Committer:  Paul E. McKenney <paulmck@...ux.ibm.com>
CommitDate: Mon, 12 Nov 2018 09:06:22 -0800

smsc: Replace spin_is_locked() with lockdep

lockdep_assert_held() is better suited to checking locking requirements,
since it only checks if the current thread holds the lock regardless of
whether someone else does. This is also a step towards possibly removing
spin_is_locked().

Signed-off-by: Lance Roy <ldr709@...il.com>
Cc: Steve Glendinning <steve.glendinning@...well.net>
Cc: "David S. Miller" <davem@...emloft.net>
Cc: <netdev@...r.kernel.org>
Signed-off-by: Paul E. McKenney <paulmck@...ux.ibm.com>
---
 drivers/net/ethernet/smsc/smsc911x.h | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/net/ethernet/smsc/smsc911x.h b/drivers/net/ethernet/smsc/smsc911x.h
index 8d75508acd2b..51b2fc1a395f 100644
--- a/drivers/net/ethernet/smsc/smsc911x.h
+++ b/drivers/net/ethernet/smsc/smsc911x.h
@@ -67,7 +67,7 @@
 
 #ifdef CONFIG_DEBUG_SPINLOCK
 #define SMSC_ASSERT_MAC_LOCK(pdata) \
-		WARN_ON_SMP(!spin_is_locked(&pdata->mac_lock))
+		lockdep_assert_held(&pdata->mac_lock)
 #else
 #define SMSC_ASSERT_MAC_LOCK(pdata) do {} while (0)
 #endif				/* CONFIG_DEBUG_SPINLOCK */