[<prev] [next>] [day] [month] [year] [list]
Message-ID: <tip-5da54c1810e52f7abba0ff7932dddd761f945875@git.kernel.org>
Date: Tue, 4 Dec 2018 14:50:01 -0800
From: "tip-bot for Paul E. McKenney" <tipbot@...or.com>
To: linux-tip-commits@...r.kernel.org
Cc: hpa@...or.com, davem@...emloft.net, tglx@...utronix.de,
edumazet@...gle.com, netdev@...r.kernel.org, mingo@...nel.org,
paulmck@...ux.ibm.com
Subject: [tip:core/rcu] net/core: Replace call_rcu_bh() and
synchronize_rcu_bh()
Commit-ID: 5da54c1810e52f7abba0ff7932dddd761f945875
Gitweb: https://git.kernel.org/tip/5da54c1810e52f7abba0ff7932dddd761f945875
Author: Paul E. McKenney <paulmck@...ux.ibm.com>
AuthorDate: Tue, 6 Nov 2018 19:43:32 -0800
Committer: Paul E. McKenney <paulmck@...ux.ibm.com>
CommitDate: Sat, 1 Dec 2018 12:38:47 -0800
net/core: Replace call_rcu_bh() and synchronize_rcu_bh()
Now that call_rcu()'s callback is not invoked until after all bh-disable
regions of code have completed (in addition to explicitly marked
RCU read-side critical sections), call_rcu() can be used in place of
call_rcu_bh(). Similarly, synchronize_rcu() can be used in place of
synchronize_rcu_bh(). This commit therefore makes these changes.
Signed-off-by: Paul E. McKenney <paulmck@...ux.ibm.com>
Cc: "David S. Miller" <davem@...emloft.net>
Cc: Eric Dumazet <edumazet@...gle.com>
Cc: <netdev@...r.kernel.org>
---
net/core/netpoll.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/net/core/netpoll.c b/net/core/netpoll.c
index 5da9552b186b..677d3f332172 100644
--- a/net/core/netpoll.c
+++ b/net/core/netpoll.c
@@ -800,7 +800,7 @@ void __netpoll_cleanup(struct netpoll *np)
ops->ndo_netpoll_cleanup(np->dev);
RCU_INIT_POINTER(np->dev->npinfo, NULL);
- call_rcu_bh(&npinfo->rcu, rcu_cleanup_netpoll_info);
+ call_rcu(&npinfo->rcu, rcu_cleanup_netpoll_info);
} else
RCU_INIT_POINTER(np->dev->npinfo, NULL);
}
@@ -811,7 +811,7 @@ void __netpoll_free(struct netpoll *np)
ASSERT_RTNL();
/* Wait for transmitting packets to finish before freeing. */
- synchronize_rcu_bh();
+ synchronize_rcu();
__netpoll_cleanup(np);
kfree(np);
}
Powered by blists - more mailing lists