netdev - [tip:core/rcu] net/core/skmsg: Replace call_rcu_sched() with call

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [day] [month] [year] [list]

Message-ID: <tip-0245b80e284d4fdabbf50589180482dc4d2cf277@git.kernel.org>
Date:   Tue, 4 Dec 2018 14:53:25 -0800
From:   "tip-bot for Paul E. McKenney" <tipbot@...or.com>
To:     linux-tip-commits@...r.kernel.org
Cc:     tglx@...utronix.de, john.fastabend@...il.com, mingo@...nel.org,
        hpa@...or.com, netdev@...r.kernel.org, daniel@...earbox.net,
        davem@...emloft.net, paulmck@...ux.ibm.com
Subject: [tip:core/rcu] net/core/skmsg: Replace call_rcu_sched() with
 call_rcu()

Commit-ID:  0245b80e284d4fdabbf50589180482dc4d2cf277
Gitweb:     https://git.kernel.org/tip/0245b80e284d4fdabbf50589180482dc4d2cf277
Author:     Paul E. McKenney <paulmck@...ux.ibm.com>
AuthorDate: Wed, 7 Nov 2018 15:09:25 -0800
Committer:  Paul E. McKenney <paulmck@...ux.ibm.com>
CommitDate: Sat, 1 Dec 2018 12:38:50 -0800

net/core/skmsg: Replace call_rcu_sched() with call_rcu()

Now that call_rcu()'s callback is not invoked until after all
preempt-disable regions of code have completed (in addition to explicitly
marked RCU read-side critical sections), call_rcu() can be used in place
of call_rcu_sched().  This commit therefore makes that change.

Signed-off-by: Paul E. McKenney <paulmck@...ux.ibm.com>
Cc: John Fastabend <john.fastabend@...il.com>
Cc: Daniel Borkmann <daniel@...earbox.net>
Cc: "David S. Miller" <davem@...emloft.net>
Cc: <netdev@...r.kernel.org>
---
 net/core/skmsg.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/net/core/skmsg.c b/net/core/skmsg.c
index 56a99d0c9aa0..c92d6ccce610 100644
--- a/net/core/skmsg.c
+++ b/net/core/skmsg.c
@@ -580,7 +580,7 @@ void sk_psock_drop(struct sock *sk, struct sk_psock *psock)
 	write_unlock_bh(&sk->sk_callback_lock);
 	sk_psock_clear_state(psock, SK_PSOCK_TX_ENABLED);
 
-	call_rcu_sched(&psock->rcu, sk_psock_destroy);
+	call_rcu(&psock->rcu, sk_psock_destroy);
 }
 EXPORT_SYMBOL_GPL(sk_psock_drop);