netdev - Re: consistency for statistics with XDP mode

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20181203232418.287795a8@cakuba.netronome.com>
Date:   Mon, 3 Dec 2018 23:24:18 -0800
From:   Jakub Kicinski <jakub.kicinski@...ronome.com>
To:     Toke Høiland-Jørgensen <toke@...e.dk>
Cc:     David Miller <davem@...emloft.net>, dsahern@...il.com,
        brouer@...hat.com, saeedm@...lanox.com, mst@...hat.com,
        netdev@...r.kernel.org, pstaszewski@...are.pl, jasowang@...hat.com
Subject: Re: consistency for statistics with XDP mode

On Tue, 04 Dec 2018 09:03:52 +0200, Toke Høiland-Jørgensen wrote:
> David Miller <davem@...emloft.net> writes:
> 
> > From: David Ahern <dsahern@...il.com>
> > Date: Mon, 3 Dec 2018 17:15:03 -0700
> >  
> >> So, instead of a program tag which the program writer controls, how
> >> about some config knob that an admin controls that says at attach time
> >> use standard stats?  
> >
> > How about, instead of replacing it is in addition to, and admin can
> > override?  
> 
> Yeah, I was also thinking about something the program writer can set,
> but the admin can override. There could even be a system-wide setting
> that would make the verifier inject it into all programs at load time?

That'd be far preferable, having all drivers include the code when we
have JITs seems like a step backward.

We could probably fit the stats into the enormous padding of struct
xdp_rxq_info, the question is - how do we get to it in a clean way..