netdev - Re: [Patch net v2] mlx5: fixup checksum for short ethernet frame padding

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Wed, 5 Dec 2018 01:06:14 +0000
From:   Saeed Mahameed <saeedm@...lanox.com>
To:     "saeedm@....mellanox.co.il" <saeedm@....mellanox.co.il>,
        "xiyou.wangcong@...il.com" <xiyou.wangcong@...il.com>
CC:     "davem@...emloft.net" <davem@...emloft.net>,
        "netdev@...r.kernel.org" <netdev@...r.kernel.org>,
        "edumazet@...gle.com" <edumazet@...gle.com>
Subject: Re: [Patch net v2] mlx5: fixup checksum for short ethernet frame
 padding

On Tue, 2018-12-04 at 12:50 -0800, Cong Wang wrote:
> On Tue, Dec 4, 2018 at 11:21 AM Saeed Mahameed
> <saeedm@....mellanox.co.il> wrote:
> > we are still working on it.
> 
> No, I give up.
> 
> Sorry for wasting time. Let's save everyone's time by discarding it!!
> :)

Hi Cong, sorry to hear that, i will take your patch evaluate and test
personally, will do the needed changes and post it later.

for now i feel that you don't want csum complete in your servers and we
already have the tool for that, just do:

ethtool --set-priv-flags <ifname> rx_no_csum_complete on
ethtool --show-priv-flags <ifname>
Private flags for p5p1:
rx_cqe_moder       : on
tx_cqe_moder       : off
rx_cqe_compress    : off
rx_striding_rq     : off
rx_no_csum_complete: on

this will disable csum complete and avoid the csum error for padded
short packets.


Thanks,
Saeed.