netdev - Re: [PATCH RFC 1/6] net: dsa: microchip: Prepare PHY for proper advertisement

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20181205174055.GE12484@lunn.ch>
Date:   Wed, 5 Dec 2018 18:40:55 +0100
From:   Andrew Lunn <andrew@...n.ch>
To:     Tristram.Ha@...rochip.com
Cc:     Florian Fainelli <f.fainelli@...il.com>,
        Pavel Machek <pavel@....cz>, UNGLinuxDriver@...rochip.com,
        netdev@...r.kernel.org
Subject: Re: [PATCH RFC 1/6] net: dsa: microchip: Prepare PHY for proper
 advertisement

On Mon, Dec 03, 2018 at 03:34:52PM -0800, Tristram.Ha@...rochip.com wrote:
> From: Tristram Ha <Tristram.Ha@...rochip.com>
> 
> Prepare PHY for proper advertisement and get link status for the port.
> 
> Signed-off-by: Tristram Ha <Tristram.Ha@...rochip.com>
> Reviewed-by: Woojung Huh <Woojung.Huh@...rochip.com>
> ---
>  drivers/net/dsa/microchip/ksz9477.c    | 12 ++++++++++++
>  drivers/net/dsa/microchip/ksz_common.c | 17 +++++++++++++++++
>  drivers/net/dsa/microchip/ksz_common.h |  2 ++
>  drivers/net/dsa/microchip/ksz_priv.h   |  2 ++
>  4 files changed, 33 insertions(+)
> 
> diff --git a/drivers/net/dsa/microchip/ksz9477.c b/drivers/net/dsa/microchip/ksz9477.c
> index 0684657..98aa25e 100644
> --- a/drivers/net/dsa/microchip/ksz9477.c
> +++ b/drivers/net/dsa/microchip/ksz9477.c
> @@ -969,6 +969,16 @@ static void ksz9477_port_mirror_del(struct dsa_switch *ds, int port,
>  			     PORT_MIRROR_SNIFFER, false);
>  }
>  
> +static void ksz9477_phy_setup(struct ksz_device *dev, int port,
> +			      struct phy_device *phy)
> +{
> +	if (port < dev->phy_port_cnt) {
> +		/* SUPPORTED_Asym_Pause and SUPPORTED_Pause can be removed to
> +		 * disable flow control when rate limiting is used.
> +		 */
> +	}

Hi Tristram

Is this meant to be a TODO comment?

What is supposed to happen here is that all forms of pause are disable
by default. The MAC driver needs to enable what it supports by calling
phy_support_sym_pause() or phy_support_asym_pause().

Ah, is this because there is not a real PHY driver?

Thanks
	Andrew