netdev - Re: [PATCH mlx5-next 2/4] net/mlx5: Use helper to get CQE opcode

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <1abfc90263b23f43d9b1896350846e4e9d334bdf.camel@mellanox.com>
Date:   Wed, 5 Dec 2018 22:37:03 +0000
From:   Saeed Mahameed <saeedm@...lanox.com>
To:     "xiyou.wangcong@...il.com" <xiyou.wangcong@...il.com>
CC:     Jason Gunthorpe <jgg@...lanox.com>,
        "netdev@...r.kernel.org" <netdev@...r.kernel.org>,
        Leon Romanovsky <leonro@...lanox.com>,
        "linux-rdma@...r.kernel.org" <linux-rdma@...r.kernel.org>,
        Tariq Toukan <tariqt@...lanox.com>
Subject: Re: [PATCH mlx5-next 2/4] net/mlx5: Use helper to get CQE opcode

On Tue, 2018-12-04 at 20:55 -0800, Cong Wang wrote:
> On Tue, Dec 4, 2018 at 6:06 PM Saeed Mahameed <saeedm@...lanox.com>
> wrote:
> > +static inline u8 get_cqe_opcode(struct mlx5_cqe64 *cqe)
> 
> Make it const please.

Please be specific

I can do:
static inline u8 get_cqe_opcode(struct mlx5_cqe64 const *cqe)
if that what you mean.

But i will leave it for a later time to do it for all cqe fields getter
functions in this file, i will keep the code uniform for now.