netdev - Re: [PATCH v2 1/2] net: mvpp2: fix detection of 10G SFP modules

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20181204.211740.1469568487731272885.davem@davemloft.net>
Date:   Tue, 04 Dec 2018 21:17:40 -0800 (PST)
From:   David Miller <davem@...emloft.net>
To:     baruch@...s.co.il
Cc:     netdev@...r.kernel.org, linux@...linux.org.uk,
        maxime.chevallier@...tlin.com, antoine.tenart@...tlin.com
Subject: Re: [PATCH v2 1/2] net: mvpp2: fix detection of 10G SFP modules

From: Baruch Siach <baruch@...s.co.il>
Date: Tue,  4 Dec 2018 16:03:52 +0200

> The mvpp2_phylink_validate() relies on the interface field of
> phylink_link_state to determine valid link modes. However, when called
> from phylink_sfp_module_insert() this field in not initialized. The
> default switch case then excludes 10G link modes. This allows 10G SFP
> modules that are detected correctly to be configured at max rate of
> 2.5G.
> 
> Catch the uninitialized PHY mode case, and allow 10G rates.
> 
> Fixes: d97c9f4ab000b ("net: mvpp2: 1000baseX support")
> Cc: Maxime Chevallier <maxime.chevallier@...tlin.com>
> Cc: Antoine Tenart <antoine.tenart@...tlin.com>
> Acked-by: Russell King <rmk+kernel@...linux.org.uk>
> Signed-off-by: Baruch Siach <baruch@...s.co.il>

Applied.