netdev - Re: [PATCH net-next 1/3] net: bridge: convert multicast to generic rhashtable

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Thu, 6 Dec 2018 23:56:17 +0800
From:   kbuild test robot <lkp@...el.com>
To:     Nikolay Aleksandrov <nikolay@...ulusnetworks.com>
Cc:     kbuild-all@...org, netdev@...r.kernel.org,
        roopa@...ulusnetworks.com, davem@...emloft.net,
        Nikolay Aleksandrov <nikolay@...ulusnetworks.com>
Subject: Re: [PATCH net-next 1/3] net: bridge: convert multicast to generic
 rhashtable

Hi Nikolay,

I love your patch! Yet something to improve:

[auto build test ERROR on net-next/master]

url:    https://github.com/0day-ci/linux/commits/Nikolay-Aleksandrov/net-bridge-convert-multicast-to-generic-rhashtable/20181206-163438
config: mips-rt305x_defconfig (attached as .config)
compiler: mipsel-linux-gnu-gcc (Debian 7.2.0-11) 7.2.0
reproduce:
        wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
        chmod +x ~/bin/make.cross
        # save the attached .config to linux build tree
        GCC_VERSION=7.2.0 make.cross ARCH=mips 

All error/warnings (new ones prefixed by >>):

   In file included from net/bridge/br.c:24:0:
   net/bridge/br_private.h: In function 'br_mdb_hash_init':
>> net/bridge/br_private.h:821:1: warning: no return statement in function returning non-void [-Wreturn-type]
    }
    ^
--
   In file included from include/trace/events/bridge.h:10:0,
                    from net/bridge/br_fdb.c:28:
   include/trace/events/../../../net/bridge/br_private.h: In function 'br_mdb_hash_init':
>> include/trace/events/../../../net/bridge/br_private.h:821:1: warning: no return statement in function returning non-void [-Wreturn-type]
    }
    ^
--
   In file included from net/bridge/br_device.c:23:0:
   net/bridge/br_private.h: In function 'br_mdb_hash_init':
>> net/bridge/br_private.h:821:1: warning: no return statement in function returning non-void [-Wreturn-type]
    }
    ^
   In file included from include/linux/timer.h:5:0,
                    from include/linux/netdevice.h:28,
                    from net/bridge/br_device.c:15:
   net/bridge/br_device.c: In function 'br_dev_setup':
>> net/bridge/br_device.c:439:23: error: 'struct net_bridge' has no member named 'mdb_list'; did you mean 'fdb_list'?
     INIT_HLIST_HEAD(&br->mdb_list);
                          ^
   include/linux/list.h:680:32: note: in definition of macro 'INIT_HLIST_HEAD'
    #define INIT_HLIST_HEAD(ptr) ((ptr)->first = NULL)
                                   ^~~
--
   In file included from net/bridge/br_netlink.c:21:0:
   net/bridge/br_private.h: In function 'br_mdb_hash_init':
>> net/bridge/br_private.h:821:1: warning: no return statement in function returning non-void [-Wreturn-type]
    }
    ^
   net/bridge/br_netlink.c: In function 'br_netlink_init':
>> net/bridge/br_netlink.c:1659:2: error: implicit declaration of function 'br_mdb_init'; did you mean 'br_fdb_init'? [-Werror=implicit-function-declaration]
     br_mdb_init();
     ^~~~~~~~~~~
     br_fdb_init
>> net/bridge/br_netlink.c:1670:2: error: implicit declaration of function 'br_mdb_uninit'; did you mean 'br_fdb_init'? [-Werror=implicit-function-declaration]
     br_mdb_uninit();
     ^~~~~~~~~~~~~
     br_fdb_init
   cc1: some warnings being treated as errors

vim +439 net/bridge/br_device.c

   415	
   416	void br_dev_setup(struct net_device *dev)
   417	{
   418		struct net_bridge *br = netdev_priv(dev);
   419	
   420		eth_hw_addr_random(dev);
   421		ether_setup(dev);
   422	
   423		dev->netdev_ops = &br_netdev_ops;
   424		dev->needs_free_netdev = true;
   425		dev->ethtool_ops = &br_ethtool_ops;
   426		SET_NETDEV_DEVTYPE(dev, &br_type);
   427		dev->priv_flags = IFF_EBRIDGE | IFF_NO_QUEUE;
   428	
   429		dev->features = COMMON_FEATURES | NETIF_F_LLTX | NETIF_F_NETNS_LOCAL |
   430				NETIF_F_HW_VLAN_CTAG_TX | NETIF_F_HW_VLAN_STAG_TX;
   431		dev->hw_features = COMMON_FEATURES | NETIF_F_HW_VLAN_CTAG_TX |
   432				   NETIF_F_HW_VLAN_STAG_TX;
   433		dev->vlan_features = COMMON_FEATURES;
   434	
   435		br->dev = dev;
   436		spin_lock_init(&br->lock);
   437		INIT_LIST_HEAD(&br->port_list);
   438		INIT_HLIST_HEAD(&br->fdb_list);
 > 439		INIT_HLIST_HEAD(&br->mdb_list);

---
0-DAY kernel test infrastructure                Open Source Technology Center
https://lists.01.org/pipermail/kbuild-all                   Intel Corporation

Download attachment ".config.gz" of type "application/gzip" (14355 bytes)