netdev - Re: [PATCH] gianfar: Add gfar_change

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <aea0bca93adf7ce9a6b3324420d1fee09f51a44d.camel@infinera.com>
Date:   Thu, 6 Dec 2018 16:31:45 +0000
From:   Joakim Tjernlund <Joakim.Tjernlund@...inera.com>
To:     "andrew@...n.ch" <andrew@...n.ch>
CC:     "claudiu.manoil@....com" <claudiu.manoil@....com>,
        "netdev@...r.kernel.org" <netdev@...r.kernel.org>
Subject: Re: [PATCH] gianfar: Add gfar_change_carrier()

On Thu, 2018-12-06 at 17:21 +0100, Andrew Lunn wrote:
> CAUTION: This email originated from outside of the organization. Do not click links or open attachments unless you recognize the sender and know the content is safe.
> 
> 
> > > Hi Joakim
> > > 
> > > Please could you explain the use case for this.
> > 
> > I have an eth I/F connected to an internal (on board) switch which has an external port to a mgmt network.
> > Whenever the external link is broken I want inform linux IP stack that the link is down on the internal eth
> > I/F as well. The two interfaces are isolated from the rest of the switch ports using VLANs.
> 
> Hi Jockim
> 
> What type of switch is it?
> 
> What i would expect is you use a switch driver, and that driver would
> allow access to the switches PHYs. When the external port goes down,
> the Linux interface for that port would go down. There is no need to
> change the carrier on the master interface.

I wish I had a proper DSA/Switchdev driver in place but I don't :(
Adding one is not impossible but then a lot of our user space app needs fixing so all
in all it it a fairly big project.
Anyhow, these carrier additions should be fine I think?

 Jocke