netdev - Re: [PATCH net-next 0/2] platform data controls for mdio-gpio

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <2f976fc3-7691-3190-3e66-729cfadb86a4@gmail.com>
Date:   Thu, 6 Dec 2018 09:22:27 -0800
From:   Florian Fainelli <f.fainelli@...il.com>
To:     Andrew Lunn <andrew@...n.ch>, David Miller <davem@...emloft.net>
Cc:     Heiner Kallweit <hkallweit1@...il.com>,
        netdev <netdev@...r.kernel.org>
Subject: Re: [PATCH net-next 0/2] platform data controls for mdio-gpio

Hi Andrew,

On 12/6/18 5:58 AM, Andrew Lunn wrote:
> Soon to be mainlined is an x86 platform with a Marvell switch, and a
> bit-banging MDIO bus. In order to make this work, the phy_mask of the
> MDIO bus needs to be set to prevent scanning for PHYs, and the
> phy_ignore_ta_mask needs to be set because the switch has broken
> turnaround.

This looks good, I would just make one/two changes which is to match the
internal phy_mask and phy_ignore_ta_mask types from the struct mii_bus
and use u32 instead of int.

> 
> Add a platform_data structure with these parameters.
> 
> Andrew Lunn (2):
>   net: phy: mdio-gpio: Add platform_data support for phy_mask
>   net: phy: mdio-gpio: Add phy_ignore_ta_mask to platform data
> 
>  MAINTAINERS                             |  1 +
>  drivers/net/phy/mdio-gpio.c             |  7 +++++++
>  include/linux/platform_data/mdio-gpio.h | 14 ++++++++++++++
>  3 files changed, 22 insertions(+)
>  create mode 100644 include/linux/platform_data/mdio-gpio.h
> 

-- 
Florian