netdev - Re: [PATCH] gianfar: Add gfar_change

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <c4ec3da0eae79aaef4c9436f5d7a72b38387c8b2.camel@infinera.com>
Date:   Thu, 6 Dec 2018 18:46:44 +0000
From:   Joakim Tjernlund <Joakim.Tjernlund@...inera.com>
To:     "andrew@...n.ch" <andrew@...n.ch>
CC:     "claudiu.manoil@....com" <claudiu.manoil@....com>,
        "netdev@...r.kernel.org" <netdev@...r.kernel.org>
Subject: Re: [PATCH] gianfar: Add gfar_change_carrier()

On Thu, 2018-12-06 at 17:54 +0100, Andrew Lunn wrote:
> 
> > I wish I had a proper DSA/Switchdev driver in place but I don't :(
> > Adding one is not impossible but then a lot of our user space app needs fixing so all
> > in all it it a fairly big project.
> > Anyhow, these carrier additions should be fine I think?
> 
> I'm not too sure about that. You are potentially messing up the state
> machine, and the MAC driver could be looking at phydev->link, which
> says up, but the carrier is down.
> 
> https://www.kernel.org/doc/Documentation/networking/operstates.txt
> 
> Could you set the interface to dormant? That seems like a better fit
> anyway:
> 
> IF_OPER_DORMANT (5):
>  Interface is L1 up, but waiting for an external event, f.e. for a
>  protocol to establish. (802.1X)
> 
> The interface does have L1 to the switch, but you are waiting for the
> external interface to go up. You can set this from user space without
> needing any kernel changes.

I can have a look at using dormant, but what is change_carrier supposed to do if
not this?

I didn't find a tool for DORMANT, I guess i will have to write one myself(using SIOCGIFFLAGS, SIOCSIFFLAGS)?